Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to zf3 functionality #7

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

shipleyr
Copy link
Collaborator

No description provided.

@shipleyr
Copy link
Collaborator Author

@mtudor I've updated the module as we discussed. At the moment it's only ZF3 compatible in my PR. I've removed the Autoloader stuff and allow composer to manage the autoloading. I've also removed the empty Module.php file as technically this isn't a module it's a library so the Module.php file is not needed. I've also assumed the structure will be as we discussed.

I'm bothered by trying to keep this ZF2 and ZF3 compatible in the same code base. I think the best way would be to create a ZF2 branch as no changes happen in there and that stays as is then we create develop and master to be ZF3 only. That way the 1.X tags will be ZF2 and then we create a 2.X tags for zf3. That keeps it as lightweight as possible. Let me know what you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants